Only use NOSHARE_DELETE if accessible#7304
Merged
headius merged 1 commit intojruby:jruby-9.3from Aug 15, 2022
Merged
Conversation
The NOSHARE_DELETE ExtendedOption is not always available on all systems, since it is part of a com.sun package that's not a public API on recent JDKs. This commit guards its use, falling back on the default NIO behavior of SHARE_DELETE when we can't access the sole option that would turn it off. Fixes jruby#7268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NOSHARE_DELETE ExtendedOption is not always available on all
systems, since it is part of a com.sun package that's not a public
API on recent JDKs. This commit guards its use, falling back on
the default NIO behavior of SHARE_DELETE when we can't access the
sole option that would turn it off.
Fixes #7268