Fix included_modules method to not return wrapped modules#7303
Merged
enebo merged 1 commit intojruby:jruby-9.3from Aug 24, 2022
Merged
Fix included_modules method to not return wrapped modules#7303enebo merged 1 commit intojruby:jruby-9.3from
enebo merged 1 commit intojruby:jruby-9.3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered this issue while investigating #7256
The included_modules method would sometimes include a wrapped module. With this change, the prepended module now shows up in this list, and not the anonymous/wrapped module (which looks to be just a JRuby implementation detail). included_modules now matches what CRuby returns for this case