Skip to content

Fix for issue 7256: Undefined constants when including a module that has been prepended#7299

Closed
evaniainbrooks wants to merge 5 commits intojruby:masterfrom
evaniainbrooks:master
Closed

Fix for issue 7256: Undefined constants when including a module that has been prepended#7299
evaniainbrooks wants to merge 5 commits intojruby:masterfrom
evaniainbrooks:master

Conversation

@evaniainbrooks
Copy link
Contributor

Fixes #7256

@enebo enebo added this to the JRuby 9.3.7.0 milestone Aug 11, 2022
@enebo
Copy link
Member

enebo commented Aug 11, 2022

@evaniainbrooks can you swap this from master to jruby-9.3? If github has a UI which allows me to make that change I cannot find it :)

@enebo
Copy link
Member

enebo commented Aug 11, 2022

I did kick it off against master anyways to also approve CI run since you are first time contributor.

@enebo enebo requested a review from headius August 11, 2022 14:38
@enebo
Copy link
Member

enebo commented Aug 11, 2022

I added @headius for reviewing this. I approve this but it is mildly scary stuff in possible impact so we should double up on the review. I think the PR is intuitive that the wrappers we make for include/prepend don't contain their own constants. So we should be asking something for it and I believe origin is correct. The actual vocabulary for this has always been confusing. Last year I did a bunch of work on fixing some issues in prepend and I already forgot.

@evaniainbrooks This is a pretty deep-level sort of fix. We appreciate the PR!

@evaniainbrooks evaniainbrooks changed the base branch from master to jruby-9.3 August 11, 2022 18:49
@evaniainbrooks evaniainbrooks changed the base branch from jruby-9.3 to master August 11, 2022 18:49
@evaniainbrooks
Copy link
Contributor Author

Thank you for the feedback @enebo

I re-created this PR against the jruby-9.3 branch here: #7302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined constants when including a module that has been prepended

2 participants