Fixing IO.binwrite specs, parsing options.#729
Closed
josedonizetti wants to merge 1 commit intojruby:masterfrom
Closed
Fixing IO.binwrite specs, parsing options.#729josedonizetti wants to merge 1 commit intojruby:masterfrom
josedonizetti wants to merge 1 commit intojruby:masterfrom
Conversation
Member
|
In Also if you are looking for a non-deprecated method I think |
Member
Author
|
@atambo: great tips, thanks! learned some new things about tagged testing and way of running mri tests, till now I was only worrying about rubyspecs. |
Closed
Member
Author
|
@atambo has a code to fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@headius @enebo @atambo Fixing binwrites specs. And as the hasOffset flag was removed and the mode calculation was done inline on the binwrite method I felt the necessity to parse mode in a string format to an int oflag. I've found a deprecated method that does this conversion, I know it is not the perfect world if you can give me feedback on other method that does the same thing.
EncodingUtils has a method that kind of does the same thing, but it depends on a file instance which I don't have.
(the deprecated method is ModeFlags. getOFlagsFromString)
Thoughts?