Clear errinfo after each finalizer runs#7288
Merged
headius merged 1 commit intojruby:jruby-9.3from Aug 9, 2022
Merged
Conversation
In jruby#7267 we had a report of endless exception cause processing that turned out to be triggered by a bad finalizer (that allowed an exception to bubble out) stacking up causes from previous calls of that finalizer. The fix here mimics what CRuby does: where they reset the errinfo to what it was prior to the finalizer running (because CRuby's GC often/usually runs on the current user thread), we simply clear it after each finalizer has run (because the JDK runs finalizers on a separate thread, as will our future non-JVM-finalizer version of this logic). No spec is provided yet due to the difficulty of testing GC-triggered events across VMs. See ruby/spec#935 for more details. Fixes jruby#7267
headius
force-pushed
the
clear_errinfo_after_finalize
branch
from
24353f4 to
238bcbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7267 we had a report of endless exception cause processing
that turned out to be triggered by a bad finalizer (that allowed
an exception to bubble out) stacking up causes from previous calls
of that finalizer.
The fix here mimics what CRuby does: where they reset the errinfo
to what it was prior to the finalizer running (because CRuby's GC
often/usually runs on the current user thread), we simply clear it
after each finalizer has run (because the JDK runs finalizers on
a separate thread, as will our future non-JVM-finalizer version of
this logic).
No spec is provided yet due to the difficulty of testing
GC-triggered events across VMs. See ruby/spec#935
for more details.
Fixes #7267