Fixed issue with ArgumentError and time formatting#7285
Merged
headius merged 4 commits intojruby:masterfrom Aug 4, 2022
Merged
Fixed issue with ArgumentError and time formatting#7285headius merged 4 commits intojruby:masterfrom
headius merged 4 commits intojruby:masterfrom
Conversation
Contributor
Author
|
I removed the format specifiers for Time due to failing tests |
headius
requested changes
Aug 4, 2022
Member
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
Minor formatting change but otherwise good.
Member
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7265
RubyTime.atMultiwould be passedarg3asnilif it wasn't given by the user. It complained that the unit couldn't be found.So I added a check to see if it is
nil, if it is then it is set to a symbol:microsecond. This appears to be the default value in CRuby.Also updated the formatting as it wasn't the same as Ruby 3.
My Ruby Version: ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu]
Example Code:
Ruby:
JRuby after PR: