Eliminate JI-specific const replacement warning#7280
Merged
headius merged 1 commit intojruby:jruby-9.3from Aug 9, 2022
Merged
Conversation
This warning duplicates existing functionality intended to warn when overwriting a constant, perhaps due to the more "magic" nature of include_package and its open-ended behavior of assigning constants to Java classes on demand. This feature is expected to be used in places where you explicitly want the Java classes to be preferred over classes further up in the hierarchy, so I believe it makes sense to only warn if overwriting a constant that exists on the target module directly. Fixes jruby#7185
headius
force-pushed
the
no_java_package_replace_warning
branch
from
ba64eff to
cff160d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning duplicates existing functionality intended to warn
when overwriting a constant, perhaps due to the more "magic"
nature of include_package and its open-ended behavior of assigning
constants to Java classes on demand. This feature is expected to
be used in places where you explicitly want the Java classes to be
preferred over classes further up in the hierarchy, so I believe
it makes sense to only warn if overwriting a constant that exists
on the target module directly.
Fixes #7185