Fix string concatenation with a number as per rubyspec behaviour.#727
Merged
headius merged 1 commit intojruby:masterfrom May 21, 2013
Merged
Fix string concatenation with a number as per rubyspec behaviour.#727headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
Following tychobrailleur/jcodings@8536b4f, the incorrect behaviour of String#concat with a number was made obvious by throwing an EncodingException. MRI changes the encoding of the String if the concatenated codepoint is within ASCII-8BIT range, and throws a RangeError otherwise.
headius
added a commit
that referenced
this pull request
May 21, 2013
Fix string concatenation with a number as per rubyspec behaviour.
Member
|
Please try to remember to set a milestone for closed issues :-) |
Contributor
Author
|
@headius Oh, did I close that issue? |
Contributor
Author
|
@headius Never mind, gotcha! (= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following tychobrailleur/jcodings@8536b4f, the incorrect behaviour of String#concat with
a number was made obvious by throwing an EncodingException. MRI changes
the encoding of the String if the concatenated codepoint is within
ASCII-8BIT range, and throws a RangeError otherwise.