Skip to content

update jar-dependencies gem hooks#7264

Merged
headius merged 1 commit intojruby:jruby-9.3from
ccutrer:jar-dependencies-hook-9.3
Aug 3, 2022
Merged

update jar-dependencies gem hooks#7264
headius merged 1 commit intojruby:jruby-9.3from
ccutrer:jar-dependencies-hook-9.3

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jul 2, 2022

fixes #7262, but requires https://github.com/mkristian/jar-dependencies to have a new release first.

fixes jruby#7262, but requires
jruby/jar-dependencies#78 to be merged
and released first.
@headius headius added this to the JRuby 9.3.7.0 milestone Aug 3, 2022
@headius headius merged commit 7daa05a into jruby:jruby-9.3 Aug 3, 2022
@headius
Copy link
Member

headius commented Aug 3, 2022

Done, thank you for your help on this!

@headius
Copy link
Member

headius commented Aug 4, 2022

@ccutrer I guess I should have forced a CI run after releasing... this seems to have broken something:

https://github.com/jruby/jruby/runs/7656938830?check_suite_focus=true

We'll need to revert or fix this before 9.3.7.0. I will create the revert PR, but hoping you can figure out what went wrong!

cc @enebo @mkristian

@ccutrer
Copy link
Contributor Author

ccutrer commented Aug 5, 2022

so it looks like the embedded jar-dependencies gem didn't get updated. looking into it now...

@ccutrer
Copy link
Contributor Author

ccutrer commented Aug 5, 2022

#7291

@headius
Copy link
Member

headius commented Aug 5, 2022

Oops! Somehow I thought that was in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants