Closed
Conversation
fixes jruby#7262, but requires jruby/jar-dependencies#78 to be merged and released first.
Member
|
Hey thanks! Do you think you could rebase this on JRuby 9.3 (branch jruby-9.3)? I think it is basically the same change and certainly relevant to 9.3 as well. Happy to merge this in whenever you can do that! |
Contributor
Author
|
yup, it was an no-conflict rebase: #7264. I'm not sure how you manage your branches (if you merge from master to 9.3, vice versa, or neither), so I just opened a separate PR so you can go either way. The gem's PR has been merged, but it still needs a release before the jruby side can be merged. |
Member
|
We merge forward from 9.3 into master so we will merge this once the new gem is released and merge from there. Thank you! |
Member
|
Superseded by #7264. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7262, but requires
jruby/jar-dependencies#78 to be merged
and released first.