Fixes #7102. ArgumentError re-splatting empty keyword arguments#7147
Merged
enebo merged 1 commit intojruby:jruby-9.3from Mar 18, 2022
Merged
Fixes #7102. ArgumentError re-splatting empty keyword arguments#7147enebo merged 1 commit intojruby:jruby-9.3from
enebo merged 1 commit intojruby:jruby-9.3from
Conversation
Went with marking incoming key word rest arguments getting marked with a flag indicating that it is a kwrest. The flag is removed once we enter check_arity helper. A kwrest is transient and isolated from the call site to the method which recieves it. So there is no opportunity for more than one thread to see this or other shenanigans like that. This also is the general direction of Ruby 3 where we (and MRI) mark kwargs hashes with a flag. We seem to fail there as well so we might actually need this new flag there (since kw and kwrest will have different behavior when passed to a method like the one attached to jruby#7102).
Member
Author
|
Something weird with CI where it will say ERROR: for like an hour and then the real results will eventually show up. The errors in my CI run seem to be exclusively from logger errors (unrelated to my changes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went with marking incoming key word rest arguments getting marked with
a flag indicating that it is a kwrest. The flag is removed once we
enter check_arity helper. A kwrest is transient and isolated from the
call site to the method which recieves it. So there is no opportunity
for more than one thread to see this or other shenanigans like that.
This also is the general direction of Ruby 3 where we (and MRI) mark
kwargs hashes with a flag. We seem to fail there as well so we might
actually need this new flag there (since kw and kwrest will have different
behavior when passed to a method like the one attached to #7102).