Skip to content

Disallow circular causes#7145

Merged
headius merged 1 commit intojruby:jruby-9.3from
headius:no_circular_cause
Mar 17, 2022
Merged

Disallow circular causes#7145
headius merged 1 commit intojruby:jruby-9.3from
headius:no_circular_cause

Conversation

@headius
Copy link
Member

@headius headius commented Mar 17, 2022

Fixes #7035

@headius headius added this to the JRuby 9.3.4.0 milestone Mar 17, 2022
@headius headius force-pushed the no_circular_cause branch from 43834e7 to bd2595c Compare March 17, 2022 12:58
@headius headius merged commit 7cf9ec9 into jruby:jruby-9.3 Mar 17, 2022
@headius headius deleted the no_circular_cause branch March 17, 2022 14:46
robbavey added a commit to elastic/logstash that referenced this pull request May 16, 2022
The addition of jruby/jruby#7145 to disallow circular
causes, will throw when `polyglot` is thrown into the mix, and stop logstash from
starting and building - any gems that use an exception to determine whether or not
to load the native gem, will trigger the code added in that commit.

This commit adds a monkey patch of `require` to rollback the circular cause exception
back to the original cause.
robbavey added a commit to elastic/logstash that referenced this pull request May 17, 2022
The addition of jruby/jruby#7145 to disallow circular
causes, will throw when `polyglot` is thrown into the mix, and stop logstash from
starting and building - any gems that use an exception to determine whether or not
to load the native gem, will trigger the code added in that commit.

This commit adds a monkey patch of `require` to rollback the circular cause exception
back to the original cause.
robbavey added a commit to elastic/logstash that referenced this pull request May 18, 2022
The addition of jruby/jruby#7145 to disallow circular
causes, will throw when `polyglot` is thrown into the mix, and stop logstash from
starting and building - any gems that use an exception to determine whether or not
to load the native gem, will trigger the code added in that commit.

This commit adds a monkey patch of `require` to rollback the circular cause exception
back to the original cause.
robbavey added a commit to elastic/logstash that referenced this pull request May 19, 2022
This commit updates the version of jruby used in Logstash to `9.3.4.0`.

* Updates the references of `jruby` from `9.2.20.1` to `9.3.4.0`
* Updates references/locations of ruby from `2.5.0` to `2.6.0`
* Updates java imports including `org.logstash.util` to be quoted
  * Without quoting the name of the import, the following error is observed in tests:
  * `java.lang.NoClassDefFoundError: org/logstash/Util (wrong name: org/logstash/util)`
  * Maybe an instance of jruby/jruby#4861
* Adds a monkey patch to `require` to resolve compatibility issue between latest `jruby` and `polyglot` gem 
  * The addition of jruby/jruby#7145 to disallow circular
causes, will throw when `polyglot` is thrown into the mix, and stop logstash from
starting and building - any gems that use an exception to determine whether or not
to load the native gem, will trigger the code added in that commit.
  * This commit adds a monkey patch of `require` to rollback the circular cause exception
back to the original cause.
* Removes the use of the deprecated `JavaClass`
* Adds additional `require time` in `generate_build_metadata`
* Rewrites a test helper to avoid potentially calling `~>` on `FalseClass`


Co-authored-by: Joao Duarte <jsvduarte@gmail.com>
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant