Skip to content

[aarch64] fix unrecognized command -m64 for native extensions#7133

Merged
headius merged 1 commit intojruby:jruby-9.3from
ahorek:aarchfix
Mar 10, 2022
Merged

[aarch64] fix unrecognized command -m64 for native extensions#7133
headius merged 1 commit intojruby:jruby-9.3from
ahorek:aarchfix

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Mar 10, 2022 •
edited
Loading

jruby 9.4.0.0-SNAPSHOT (3.1.0) 2022-03-10 0b09e54 OpenJDK 64-Bit Server VM 25.292-b10 on 1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 +jit [linux-aarch64]

Fetching sassc-2.4.0.gem
Building native extensions. This could take a while...
ERROR:  Error installing sassc:
        ERROR: Failed to build gem native extension.

    current directory: /home/jruby/lib/ruby/gems/shared/gems/sassc-2.4.0/ext
/home/jruby/bin/jruby -I /home/jruby/lib/ruby/stdlib -r ./siteconf20220310-9324-qbakp6.rb extconf.rb
creating Makefile

current directory: /home/jruby/lib/ruby/gems/shared/gems/sassc-2.4.0/ext
make DESTDIR\= clean

current directory: /home/jruby/lib/ruby/gems/shared/gems/sassc-2.4.0/ext
make DESTDIR\=
compiling ./libsass/src/ast.cpp
c++: error: unrecognized command line option '-m64'
make: *** [Makefile:196: ast.o] Error 1

@ahorek ahorek added this to the JRuby 9.3.4.0 milestone Mar 10, 2022
@headius
Copy link
Member

headius commented Mar 10, 2022

@ahorek I just made a similar change in #7132. What do you think?

@ahorek
Copy link
Contributor Author

ahorek commented Mar 10, 2022

this fix is different than yours. There's no problem on macOS, because archflags are overridden here:

jruby/core/src/main/java/org/jruby/ext/rbconfig/RbConfigLibrary.java

Line 428 in baa8568

String archflags = " -m" + (IS_64_BIT ? "64" : "32");

jruby/core/src/main/java/org/jruby/ext/rbconfig/RbConfigLibrary.java

Line 443 in baa8568

archflags = " -arch " + getArchitecture();

based on https://forum.odroid.com/viewtopic.php?t=34578 -m64 option should be valid for x86_64 processors only

@headius headius merged commit b788e50 into jruby:jruby-9.3 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ahorek @headius