Architecture tweaks for JRuby on M1#7132
Merged
headius merged 3 commits intojruby:jruby-9.3from Mar 10, 2022
Merged
Conversation
This should allow sassc and other external libraries to build using the makefile configuration bits in rbconfig. See sass/sassc-ruby#231
This was referenced Mar 10, 2022
Contributor
|
I have an aarch64/Linux VM up, so just let me know if you need to test something. |
Member
Author
|
@ahorek Ok thanks for confirming this and your other fix for the |
Member
Author
Oh nevermind, I guess it was already targeted at 9.3. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In sass/sassc-ruby#231 it was reported that JRuby builds an improper
ARCH_FLAGon MacOS/M1, usingaarch64when it should usearm64. This PR fixes that.This may be an appropriate change for other
aarch64platforms depending on what the compiler wants, but I do not currently have a working Linux/aarch64 system on which to test it.I also noticed that the
-voutput on JRuby reverses the arch and OS compared to CRuby, so this PR fixes that as well.Two spec tags are updated to the new
arm64arch name ondarwin.