Merged
Conversation
This may resolve issues like jruby#6669 where an in-use stream is closed in another thread. We have some races here (which may be unavoidable) that can lead to the fd field getting nulled out on the way to a read or write. Without null checks, we may raise NPE instead of a more appropriate EBADF when the fd is dereferenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may resolve issues like #6669 where an in-use stream is
closed in another thread. We have some races here (which may be
unavoidable) that can lead to the fd field getting nulled out on
the way to a read or write. Without null checks, we may raise NPE
instead of a more appropriate EBADF when the fd is dereferenced.