Merged
Conversation
Member
Member
Actually perhaps this means we could go ahead defining everything? It seems like CRuby only avoids defining these constants if the underlying platform does not provide the C defines necessary, rather than detecting if those socket features are available. I am unsure. 🤔 Waiting on @p-mongo for confirmation. |
|
I get this error when trying to build jruby-9.3: I built master successfully but the patches don't apply there. |
Contributor
Author
|
@headius CRuby does define these constants (if they're present on the platform aka jnr-constants), but it doesn't mean that any ipv6 connection has to be usable. Also, interfaces could be changed at runtime. CRuby does raise when you want to use such an address due to these differences in behavior, I think this change should be reverted we do ignore forced protocols and we have some fallbacks to ipv4, so this part doesn't work the same due to implementation differences (native socket vs java) @p-mongo these errors are weird, could you try a clean build? |
Member
|
@p-mongo That looks like a stale build. Try |
Member
|
@p-mongo any chance you can try this again with a clean build |
|
I assume the clean part worked, I am running |
|
Built was successful but the binary fails at trying to load rubygems: I normally use rbenv (and zsh), thus the first command is intended to get rid of any rbenv setup that might be loaded. |
headius
approved these changes
Mar 16, 2022
|
I realized that I was trying to test master which is 9.4, after I switched to 9.3 and rebuilt the two tests which have been previously failing are now passing. |
Member
|
@p-mongo Oh great, thank you! We will have to look into the brokenness on master, but this is merged and will be in 9.3.4! |
|
Actually my machine (without docker) may have always worked, to test this it properly I'd probably need to use the snapshot after all. |
|
Procureo Rubi token |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partly reverts #6945
see #7069