Handle unrooted break jumps in Thread#7029
Merged
headius merged 2 commits intojruby:jruby-9.3from Jan 24, 2022
Merged
Conversation
This is later in the bubbling than CRuby handles it, but we do not currently have a good way to know the break target does not exist on the current thread. Fixes jruby#7009
This was referenced Jan 24, 2022
toy
added a commit
to toy/in_threads
that referenced
this pull request
Jan 27, 2022
Assuming it contains fix from jruby/jruby#7029 for jruby/jruby#7009
toy
added a commit
to toy/in_threads
that referenced
this pull request
Jan 30, 2022
toy
added a commit
to toy/in_threads
that referenced
this pull request
Jan 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix #7009 by converting the IRBreakJump into a LocalJumpError before it bubbles completely out of the thread.
Initial attempt at this allows the jump to bubble all the way to the top of RubyRunnable before getting converted, which does not exactly match CRuby behavior. In CRuby, the jump is an LJE immediately because they search the current thread for the target scope and raise LJE immediately if it is not present. We do not want to add such a search to our break instruction.