Fixes #6993. Evals cause memory leak.#6994
Merged
enebo merged 1 commit intojruby:jruby-9.3from Jan 14, 2022
Merged
Conversation
This makes two changes. The first is to not record evals as lexical children. In IR we actually only use lexical children for IR persistence (and AOT compilation). We would never persist a live eval instance. This leads to the second change. anyUsesEval was using lexicalChildren to detect for evals when trying to perform AOT compilation (which we do not allow). This is better served by getClosures as we really only care about "soft" scopes containing an eval (e.g. we don't care if a method contains and eval if we are trying to AOT a module scope (hard scope change) but we do care about a closure in a method containing an eval (soft scope change)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes. The first is to not record evals
as lexical children. In IR we actually only use lexical
children for IR persistence (and AOT compilation). We would
never persist a live eval instance.
This leads to the second change. anyUsesEval was using lexicalChildren
to detect for evals when trying to perform AOT compilation (which we
do not allow). This is better served by getClosures as we really
only care about "soft" scopes containing an eval (e.g. we don't
care if a method contains and eval if we are trying to AOT a module
scope (hard scope change) but we do care about a closure in a method
containing an eval (soft scope change)).