Update JNR for Apple Silicon varargs support#6985
Merged
headius merged 2 commits intojruby:jruby-9.2from Jan 6, 2022
Merged
Conversation
|
Yeah! Can confirm this PR (and upstream jnr/jffi#121 + jnr/jnr-ffi#292 + jnr/jnr-posix#174) fixes #6983. Tested on macOS Monterey 12.1 aarch64 M1Max using OpenJDK@11. This is great news! Thank you! |
See the following PRs: * jnr/jffi#121 * jnr/jnr-ffi#292 * jnr/jnr-posix#174
This class was largely copied from jnr-ffi, and duplicates this logic. Patch brings over the updates for variadic function calls to support Ruby FFI on M1. See jruby#6987
This was referenced Jan 6, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will incorporate the recent work to get variadic functions working properly on Apple Silicon.