Use method location for includes/prepends#6955
Closed
headius wants to merge 1 commit intojruby:jruby-9.3from
Closed
Use method location for includes/prepends#6955headius wants to merge 1 commit intojruby:jruby-9.3from
headius wants to merge 1 commit intojruby:jruby-9.3from
Conversation
When we want to include a given module, we should be retrieving its method location. This avoids prepends, which we will mine out during the normal process of walking all modules included or prepended into the source module. Fixes jruby#6924
Member
Author
|
We went with #6954 for this instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we want to include a given module, we should be retrieving
its method location. This avoids prepends, which we will mine out
during the normal process of walking all modules included or
prepended into the source module.
Fixes #6924