Skip to content

Fix 6924#6954

Merged
enebo merged 2 commits intojruby:jruby-9.3from
enebo:fix_6924
Dec 1, 2021
Merged

Fix 6924#6954
enebo merged 2 commits intojruby:jruby-9.3from
enebo:fix_6924

Conversation

@enebo
Copy link
Member

@enebo enebo commented Dec 1, 2021

Fixes #6924.

Including modules after a prepend needs the new locations for methods.

IncludedModuleWrapper takes the real module (e.g. Enumerable) but if
the module has been prepended then all the methods get moved to a
PrependedModule. getMethodLocation returns that prependedmodule instance.

@enebo enebo changed the base branch from master to jruby-9.3 December 1, 2021 17:09
IncludedModuleWrapper takes the real module (e.g. Enumerable) but if
the module has been prepended then all the methods get moved to a
PrependedModule.  getMethodLocation returns that prependedmodule instance.
refinements use includedmodulewrapper in several places and this is
more invasive.  Also ask wrapper for methods if there are refinements.
@enebo enebo added this to the JRuby 9.3.2.0 milestone Dec 1, 2021
@enebo enebo merged commit 394fc1b into jruby:jruby-9.3 Dec 1, 2021
@enebo enebo deleted the fix_6924 branch December 1, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant