Merged
Conversation
CRuby has complicated logic for defining socket-related constants and query methods, but I believe this is a rough match for how they filter out IPv6-related constants when IPv6 is not available. This is checked by e.g. MRI tests and rubyspec to skip or alter IPv6-related tests.
Contributor
|
it's a good idea, thanks for the fix |
This was referenced Feb 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a few failures with IPv6 that have escaped notice due to not running in Travis CI. When they failed locally we probably ignored those failures assuming we did not have IPv6 set up properly.
This PR will include some fixes and some tags for IPv6-related failures we now see when running CI on GitHub Actions.
listenunless you instantiate ServerSocket. All the IPv4 specs were tagged but some IPv6 specs were untagged.