Honor the requested address even given hostname#6943
Merged
headius merged 1 commit intojruby:masterfrom Nov 16, 2021
Merged
Conversation
Previously if the hostname was given it was looked-up rather than being used with the requested address. The new logic will use the hostname if alone or hostname plus address otherwise. Also included in this patch, the array accesses now use `entry` which will return a nil for missing items. Previous use of `eltOk` would raise a ConcurrencyError if the array was not long enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the hostname was given it was looked-up rather than
being used with the requested address. The new logic will use the
hostname if alone or hostname plus address otherwise.
Also included in this patch, the array accesses now use
entrywhich will return a nil for missing items. Previous use of
eltOkwould raise a ConcurrencyError if the array was not long enough.