Suport sliced with Enumerator::ArithmeticSequence on Array#6927
Merged
enebo merged 1 commit intojruby:masterfrom Nov 24, 2021
Merged
Conversation
edipofederle
changed the title
Member
|
This feature is the only thing not passing on master's 3.0 specs. Let us know if you want some help getting it finished! |
Closed
Contributor
Author
Hi @headius, I'm planing back to work on it today or tomorrow, I let you know if I need something here. |
edipofederle
force-pushed
the
elf-array-sliced-enum-arithmetic-sequence
branch
3 times, most recently
from
26eb457 to
4be10ec
Compare
enebo
requested changes
Nov 22, 2021
Member
enebo
left a comment
enebo
left a comment
There was a problem hiding this comment.
Also I mentioned using subseq in chat.
edipofederle
force-pushed
the
elf-array-sliced-enum-arithmetic-sequence
branch
from
58c1cc2 to
66102e0
Compare
Member
|
Thanks @edipofederle! Keep these PRs coming :) |
enebo
added a commit
that referenced
this pull request
Nov 24, 2021
After #6927 landed I was planning on addressing aref not accepting ThreadContext and push it through the new code from that PR. There are two other fixes I missed from reviewing that PR: 1. In code for stepping when it is known to only be one result it never returned the result 2. The new code in a couple of places access values field directly. This will work but because Array has object shaping we prefer to call through methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support sliced with Enumerator::ArithmeticSequence on Array