Skip to content

[Feature] pager for --help - Ruby 3#6902

Merged
enebo merged 1 commit intojruby:masterfrom
edipofederle:elf-pager-for-helper-option
Nov 3, 2021
Merged

[Feature] pager for --help - Ruby 3#6902
enebo merged 1 commit intojruby:masterfrom
edipofederle:elf-pager-for-helper-option

Conversation

@edipofederle
Copy link
Contributor

@edipofederle edipofederle commented Oct 22, 2021 •
edited
Loading

Show the help message via pager if running on a tty. Feature #3000

Also, highlights headings and options in the message.

demo: https://asciinema.org/a/PXZO3Kvy8F0kxSfL7A9RkWSQV

@edipofederle edipofederle force-pushed the elf-pager-for-helper-option branch 4 times, most recently from 6b41467 to 5ed3a28 Compare October 22, 2021 15:59
@enebo
Copy link
Member

enebo commented Oct 22, 2021

@edipofederle Do you know if they do anything when on windows?

@edipofederle
Copy link
Contributor Author

edipofederle commented Oct 22, 2021 •
edited
Loading

@edipofederle Do you know if they do anything when on windows?

This is my next thing to do, not sure now. Looking at the original PR, I cannot see anything related to it.

@edipofederle edipofederle force-pushed the elf-pager-for-helper-option branch 7 times, most recently from 5a075bc to 2f3b214 Compare October 23, 2021 11:38
@edipofederle
Copy link
Contributor Author

edipofederle commented Oct 23, 2021

@enebo could you help me with the CI errors? I cannot figure out the problem. I basically remove all new code (in past builds) but it still fails. Any help will be appreciated. thanks

@enebo
Copy link
Member

enebo commented Oct 25, 2021

@edipofederle Neither of those errors are from your changes. So I wouldn't worry about them (and we are working on addressing one of them today).

Can you point to where in C ruby these changes are inspired from?

@edipofederle
Copy link
Contributor Author

edipofederle commented Oct 25, 2021

@edipofederle Neither of those errors are from your changes. So I wouldn't worry about them (and we are working on addressing one of them today).

Can you point to where in C ruby these changes are inspired from?

Hi, from this PR: ruby/ruby#3000

enebo
enebo requested changes Oct 25, 2021
View reviewed changes
Copy link
Member

@enebo enebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe whereever we have code for popen may work to use this code for piping our input to whatever PAGER we execute.

@edipofederle edipofederle force-pushed the elf-pager-for-helper-option branch from e7dadac to 8614660 Compare October 27, 2021 18:29
@edipofederle edipofederle changed the base branch from master to 1_7_20 October 27, 2021 19:11
@edipofederle edipofederle changed the base branch from 1_7_20 to master October 27, 2021 19:11
@edipofederle edipofederle changed the base branch from master to 1_7_20 October 27, 2021 19:12
@edipofederle edipofederle changed the base branch from 1_7_20 to master October 27, 2021 19:12
@edipofederle edipofederle force-pushed the elf-pager-for-helper-option branch 6 times, most recently from 44f932a to 5f30c75 Compare October 28, 2021 08:34
@edipofederle edipofederle marked this pull request as ready for review October 28, 2021 22:49
@edipofederle
Copy link
Contributor Author

edipofederle commented Oct 28, 2021

@enebo we can go ahead with this or need to wait for fixes on master?

@edipofederle edipofederle force-pushed the elf-pager-for-helper-option branch from 5f30c75 to d7a7b27 Compare November 1, 2021 08:57
@enebo enebo added this to the JRuby 9.4.0.0 milestone Nov 3, 2021
@enebo enebo merged commit b793214 into jruby:master Nov 3, 2021
@enebo
Copy link
Member

enebo commented Nov 3, 2021

Thanks @edipofederle!

@edipofederle edipofederle deleted the elf-pager-for-helper-option branch November 3, 2021 17:00
@headius
Copy link
Member

headius commented Nov 23, 2022

Link to #6878.

@headius headius mentioned this pull request Nov 23, 2022
Closed
@headius headius mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enebo enebo enebo requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@edipofederle @enebo @headius