Skip to content

Fix at_exit exception behavior to match CRuby#6879

Merged
headius merged 2 commits intojruby:masterfrom
headius:hard_exit_with_exception
Oct 7, 2021
Merged

Fix at_exit exception behavior to match CRuby#6879
headius merged 2 commits intojruby:masterfrom
headius:hard_exit_with_exception

Conversation

@headius
Copy link
Member

@headius headius commented Oct 6, 2021

  • Display error raised during at_exit as well as any run-time
    error.
  • Error during at_exit takes over exit status.
  • Exception during run-time should be handled and displayed after
    teardown.

Fixes #6874

@headius headius added this to the JRuby 9.3.1.0 milestone Oct 6, 2021
* Display error raised during at_exit as well as any run-time
  error.
* Error during at_exit takes over exit status.
* Exception during run-time should be handled and displayed after
  teardown.

Fixes jruby#6874
e.g. Kernel#at_exit specs check process output
@headius headius force-pushed the hard_exit_with_exception branch from 8b0dbde to a4f550b Compare October 7, 2021 13:39
@headius headius merged commit d664220 into jruby:master Oct 7, 2021
@headius headius deleted the hard_exit_with_exception branch October 7, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling exit! within at_exit doesn't "clear" the exception

1 participant