Fix KeyError behavior with no arguments#6861
Merged
enebo merged 1 commit intojruby:masterfrom Sep 28, 2021
Merged
Conversation
GabrielNagy
force-pushed
the
fix-key-error
branch
from
7ec32f7 to
6d2bab2
Compare
After JRuby 9.3, attempting to raise a KeyError with no arguments would fail with an ArgumentError. This commit fixes this behavior to match MRI, and updates the `key` and `receiver` methods to raise if they are unset. Prior to this, the relevant MRI tests for this functionality were not running in CI, and when ran manually 3 tests were failing. Add the `test_key_error.rb` file to the `mri.code` suite. After this change, all tests from `test_key_error.rb` pass. Fixes jruby#6860.
GabrielNagy
force-pushed
the
fix-key-error
branch
from
6d2bab2 to
38d44d0
Compare
Member
|
Thanks @GabrielNagy |
This was referenced Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After JRuby 9.3, attempting to raise a KeyError with no arguments would
fail with an ArgumentError. This commit fixes this behavior to match
MRI, and updates the
keyandreceivermethods to raise if they areunset.
Prior to this, the relevant MRI tests for this functionality were not
running in CI, and when ran manually 3 tests were failing. Add the
test_key_error.rbfile to themri.codesuite. After this change, alltests from
test_key_error.rbpass.Fixes #6860.
Relevant MRI code: https://github.com/ruby/ruby/blob/09863a4cd8eb40b34b310083d8cdda899ab5bcc1/error.c#L2096-L2121