Fix handling of ENXIO error during resource open#6852
Merged
headius merged 1 commit intojruby:masterfrom Sep 24, 2021
Merged
Conversation
This triggered a failure in the io/wait tests when it expected a nonblocking write-only open call against an unread fifo to raise ENXIO. We instead raised one of our internal anonymous errors, preventing the logic in this test from retrying: https://github.com/ruby/io-wait/blob/0c73ebcf5d75b0568405f5863eefaffba0ec7a0e/test/io/wait/test_io_wait_uncommon.rb#L23 The changes here promote all unraised errno exceptions to use ErrnoException, which propagates the errno object as well as the name and path. This allows upstream error handling to raise the proper Ruby error.
headius
added a commit
to headius/io-wait
that referenced
this pull request
Sep 24, 2021
Merged
Closed
headius
added a commit
to headius/io-wait
that referenced
this pull request
Nov 29, 2021
headius
added a commit
to headius/io-wait
that referenced
this pull request
Feb 1, 2022
nobu
pushed a commit
to nobu/io-wait
that referenced
this pull request
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This triggered a failure in the io/wait tests when it expected a
nonblocking write-only open call against an unread fifo to raise
ENXIO. We instead raised one of our internal anonymous errors,
preventing the logic in this test from retrying:
https://github.com/ruby/io-wait/blob/0c73ebcf5d75b0568405f5863eefaffba0ec7a0e/test/io/wait/test_io_wait_uncommon.rb#L23
The changes here promote all unraised errno exceptions to use
ErrnoException, which propagates the errno object as well as the
name and path. This allows upstream error handling to raise the
proper Ruby error.