Avoid alias warning if target has same reqs#6842
Merged
headius merged 1 commit intojruby:masterfrom Oct 8, 2021
Merged
Conversation
We warn when aliasing a method that requires the caller's frame due to the fact that we use those names to force methods to push a frame when they would not otherwise need it. However, if the target name represents one that has the same or a superset of frame requirements, we can safely perform the alias, knowing that the new name is already flagged globally. This patch checks whether the target name has the same or a superset of frame requirements and skips the warning. The defineAliases(..., List) form is deprecated as it does not appear to be in use by any versioned or generated code. The searchForAliasMethod method no longer performs the warning check, since the deprecated method would need to perform it for each entry and a new method checkAliasFrameAccesses does the check and warn. This relates to ruby/ostruct#30, but does not directly work around any of the issues there. It would comprise part of a workaround if we also pre-marked the instance_eval! and instance_exec! methods, but that is not currently planned (and we would rather not).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We warn when aliasing a method that requires the caller's frame
due to the fact that we use those names to force methods to push
a frame when they would not otherwise need it. However, if the
target name represents one that has the same or a superset of
frame requirements, we can safely perform the alias, knowing that
the new name is already flagged globally.
This patch checks whether the target name has the same or a
superset of frame requirements and skips the warning.
The defineAliases(..., List) form is deprecated as it does not
appear to be in use by any versioned or generated code.
The searchForAliasMethod method no longer performs the warning
check, since the deprecated method would need to perform it for
each entry and a new method checkAliasFrameAccesses does the check
and warn.
This relates to ruby/ostruct#30, but does not directly work around
any of the issues there. It would comprise part of a workaround if
we also pre-marked the instance_eval! and instance_exec! methods,
but that is not currently planned (and we would rather not).