Revert ostruct tests/specs due to reverted gem#6835
Merged
headius merged 3 commits intojruby:masterfrom Sep 16, 2021
Merged
Conversation
This reverts commit 1a7079e.
Because of ruby/ostruct#30 we were forced to revert to an older ostruct gem (which matches Ruby 2.6.8) and these specs began to fail. Tagging these failures for now in advance of a fix for the ostruct issue or some workaround in JRuby.
Member
Author
|
Ok, there's yet another out of sync gem here. The failing test is due to CRuby shipping a custom ostruct that does not match the 0.1.0 release they say it is. |
The released 0.1.0 gem, which is what 2.6.8 claims to ship, does not have the changes in this test. This is due to CRuby having made custom changes to their local copy of ostruct in the CRuby repository, and not releasing that custom version. See https://bugs.ruby-lang.org/issues/18169 We will exclude this test for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ruby/ostruct#30 for the ostruct issue that caused us to revert to an earlier gem. This PR reverts the test and tags the specs that do not pass on the older version of ostruct.
See also #6831.