Skip to content

Addrinfo#inspect add protocols#6829

Merged
enebo merged 1 commit intojruby:masterfrom
ahorek:inspect_protocols
Sep 16, 2021
Merged

Addrinfo#inspect add protocols#6829
enebo merged 1 commit intojruby:masterfrom
ahorek:inspect_protocols

Conversation

@ahorek
Copy link
Contributor

@ahorek ahorek commented Sep 14, 2021

before

'#<Addrinfo: 127.0.0.1:80>'

after

'#<Addrinfo: 127.0.0.1:80 TCP>'

@enebo enebo added this to the JRuby 9.3.0.0 milestone Sep 16, 2021
@enebo
Copy link
Member

enebo commented Sep 16, 2021

@ahorek you plan on adding name as well in another PR?

mri26 -rsocket -e 'p Addrinfo.getaddrinfo("www.google.com", 443, nil, :STREAM)'
[#<Addrinfo: 142.250.190.100:443 TCP (www.google.com)>, #<Addrinfo: [2607:f8b0:4009:805::2004]:443 TCP (www.google.com)>]
system

@enebo enebo merged commit e8e2485 into jruby:master Sep 16, 2021
@ahorek ahorek mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ahorek @enebo