Skip to content

Add optional argument to start and garbage_collect#6819

Merged
enebo merged 6 commits intojruby:masterfrom
JasonLunn:patch-2
Sep 16, 2021
Merged

Add optional argument to start and garbage_collect#6819
enebo merged 6 commits intojruby:masterfrom
JasonLunn:patch-2

Conversation

@JasonLunn
Copy link
Contributor

Proposed fix for #6818

@ahorek
Copy link
Contributor

ahorek commented Sep 10, 2021

could you also change it at https://github.com/jruby/jruby/blob/master/core/src/main/java/org/jruby/RubyObjectSpace.java#L194 and remove a tag https://github.com/jruby/jruby/blob/master/spec/tags/ruby/core/gc/start_tags.txt#L1 ?

@JasonLunn
Copy link
Contributor Author

@ahorek - thanks for the pointers - added your suggestions.
@headius - There was no spec tag to remove for the missing keyword argument support for ObjectSpace, so I assume that means there was no compliance test that was failing without it. Does one add those such a test directly in the JRuby repo, or does one need to contribute that upstream somewhere?

@ahorek
Copy link
Contributor

ahorek commented Sep 10, 2021

@ahorek
Copy link
Contributor

ahorek commented Sep 10, 2021

@headius
Copy link
Member

headius commented Sep 10, 2021

You can also add new specs to our repository directly, under spec/ruby which is equivalent to the https://github.com/ruby/spec repository.

FWIW, as you may have noticed GC.start is a no-op on JRuby, since the JVM GC is a very different beast than the CRuby GC and we do not really have direct control over it. I don't see us changing that any time soon.

@JasonLunn
Copy link
Contributor Author

Updated jruby.mspec and opened ruby/spec#849

@enebo enebo added this to the JRuby 9.3.0.0 milestone Sep 16, 2021
@enebo enebo merged commit 524d709 into jruby:master Sep 16, 2021
@JasonLunn JasonLunn deleted the patch-2 branch September 16, 2021 14:31
@headius headius linked an issue Sep 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GC.start raises ArgumentError when passed named arguments

4 participants