Conversation
I locally am seeing a random constant not found error after this commit so I think I am getting close? Not sure what is up there. Once this is fully green I will go back to the previous reported issues marked against 9.3 and hopefully they will all be fixed?
Contributor
Author
|
ok, confirmed locally and relevant tests passed. Even if it's still slower than the recent MRI, this change will improve escape/unescape performance which is important for ERB-like templates by 3 times. I think we can include it to 9.3, once tests on #6777 are green. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on the top of #6777 that should fix the issue with prepends
see #5949