Undo shared-buffer optimizations from #6557#6769
Merged
headius merged 1 commit intojruby:jruby-9.2from Aug 5, 2021
Merged
Conversation
The "optimizations" here were overzealous: * The incoming ByteBuffer and its contents should not be referenced past the end of the call, as was done here by returning a String that directly wraps the buffer's underlying array. * The copy of bytes out of the native buffer is essentially the same as calling #duplicate, so this is just unnecessary double- copying. Fixes jruby#6767.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "optimizations" in #6557 were overzealous:
referenced past the end of the call, as was done here by
returning a String that directly wraps the buffer's underlying
array.
same as calling #duplicate, so this is just unnecessary double-
copying.
Fixes #6767.