Lazily define FFI-using File methods#6760
Merged
headius merged 1 commit intojruby:masterfrom Jul 23, 2021
Merged
Conversation
Activating FFI this early prevents it being upgraded by RubyGems or Bundler. This also happens so early that there's no way to eagerly activate the gem to pick up a newer version. As a result, bundles or gems that depend on newer FFI will error or warn about the mismatch. This change modifies the FFI-based File methods on Windows (File.symlink) and Solaris (File#flock) to lazily require a separate file that loads FFI and redefines those methods. Fixes jruby#6751
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 16, 2021
See jruby#6760 and related commits to these files on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activating FFI this early prevents it being upgraded by RubyGems
or Bundler. This also happens so early that there's no way to
eagerly activate the gem to pick up a newer version. As a result,
bundles or gems that depend on newer FFI will error or warn about
the mismatch.
This change modifies the FFI-based File methods on Windows
(File.symlink) and Solaris (File#flock) to lazily require a
separate file that loads FFI and redefines those methods.
Fixes #6751