Use cached UTF8 single-char bytelists here#6700
Merged
headius merged 1 commit intojruby:jruby-9.2from Jun 5, 2021
Merged
Conversation
headius
force-pushed
the
more_singlechar_bytelists
branch
from
dee8c82 to
1a1ff85
Compare
headius
force-pushed
the
more_singlechar_bytelists
branch
3 times, most recently
from
fb0271d to
8b84829
Compare
This logic would always create a new byte[], ByteList, and RubyString when pulling single-byte characters from a multi-byte string. This change allows it to use cached ByteList (and byte[]) for those cases if the encoding is UTF-8.
headius
force-pushed
the
more_singlechar_bytelists
branch
from
8b84829 to
d84d63f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic would always create a new byte[], ByteList, and
RubyString when pulling single-byte characters from a multi-byte
string. This change allows it to use cached ByteList (and byte[])
for those cases if the encoding is UTF-8.