Also use shell for commands with a space#6685
Merged
headius merged 1 commit intojruby:jruby-9.2from May 26, 2021
Merged
Conversation
This duplicates some logic in ShellLauncher but that other logic splits the command line and tries to pass it as multiple args. This way works ok and may be more reliable for Open3 cases, plus it skips all the heinous logic in ShellLauncher. Fixes jruby#6678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This duplicates some logic in ShellLauncher but that other logic
splits the command line and tries to pass it as multiple args.
This way works ok and may be more reliable for Open3 cases, plus
it skips all the heinous logic in ShellLauncher.
Fixes #6678