Do not merge extra env with current env#6655
Merged
headius merged 1 commit intojruby:jruby-9.2from Apr 9, 2021
Merged
Conversation
The env hash is now peeled off during processing of the argument array in ShellLauncher, so this is no longer needed and was not correct in the first place (should have used a dup of ENV at best.) Fixes jruby#6554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The env hash is now peeled off during processing of the argument
array in ShellLauncher, so this is no longer needed and was not
correct in the first place (should have used a dup of ENV at
best.)
Fixes #6554