Do not assign backref from String#split#6646
Merged
headius merged 1 commit intojruby:masterfrom May 19, 2021
Merged
Conversation
String#split only appears to clear the backref, and only when passed a Regexp, so remove that logic and the frame flag for BACKREF writes. Any code relying on split to clear backref would be fragile, since altering the split to use a string would break that expectation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#split only appears to clear the backref, and only when
passed a Regexp, so remove that logic and the frame flag for
BACKREF writes.
Any code relying on split to clear backref would be fragile, since
altering the split to use a string would break that expectation.
See #6644.