Unbreak CachingCallSite.isBuiltin#6629
Conversation
During the various deprecations and undeprecations of this method, it was inadvertently broken due to switching to a cacheAndGet path that does not set the builtinCache field. Since call sites used for isBuiltin are usually *only* used for isBuiltin, I modified this to just use the standard cache field. Relates to jruby#6628
|
@kares Need your input here... you deprecated these some time ago, I believe when you were improving how we check isBuiltin for Fixnum and Float. Be my second pair of eyes and help me confirm this fix is ok and appropriate? |
|
Note that |
|
This change likely has little to no effect on #6628 but is still valid. We need to clean up all these paths and either delete them or make them solid. |
|
believe the deprecation was to prefer the public methods without the additional a bit confused why 2 caches would be needed here, the 'new' |
3 participants
During the various deprecations and undeprecations of this method,
it was inadvertently broken due to switching to a cacheAndGet path
that does not set the builtinCache field. Since call sites used
for isBuiltin are usually only used for isBuiltin, I modified
this to just use the standard cache field.
Relates to #6628