Conversation
This should be zero sum. It also went to some pains to ensure no NORMAL type is passed through places which should be PROC.
We already know it will not be a direct call and we know call it will make. This is also more of a lower call than calling back into another top-level yield.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary motivation was eliminating any NORMAL block types from making it to BlockBody.prepareArgumentForCall. This bled over into also not calling from BlockBody back to RubyProc.
All yields now convert their arguments in two paths. They all happen at the same level. All calls will use the same logic and no longer have to contend with NORMAL sneaking in.
Open work which could continue is I indirected BlockCallbackImpl to wrap a Proc. So I added a level of indirection. I find this type and RubyYielder to be another area to reexamine at a later point. We play a lot of games here to reduce overhead but it is really hard to grok it.