Conversation
The IPSocket constant gets assigned by the class definition above, and this other one is not even spelled right. See sorbet/sorbet#1216
Member
Author
|
@kares See the linked bug for a minor issue in jossl (differing ancestors for one OSSL exception). You may also be interested in the linked issues surrounding our problematic package modules, which we have tried to replace without success. |
Member
Author
|
I'm just going to merge this simple fix since the package module work is a project in itself, and the jossl issue should be filed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See sorbet/sorbet#1216
There will only be a handful of small fixes in here since the Java package module issues are rather tricky.