Remove process group to avoid hanging daemons#6582
Merged
headius merged 1 commit intojruby:jruby-9.2from Feb 28, 2021
Merged
Conversation
This was referenced Feb 26, 2021
headius
force-pushed
the
ungroup_popen
branch
from
6d05a3c to
139a5a1
Compare
In jruby#5383 we added logic to create a new process group when doing chdir in spawn, to avoid orphaning the eventual process spawned by the intermediate sh. Unfortunately this has a side effect of hanging on waitpid if the process spawns a long-running daemon. This patch removes the process group and instead uses exec in the generated sh script so that the sh process is replaced. The forked daemon lives on, as it should, but only the main process is waited on. Fixes jruby#6579
headius
force-pushed
the
ungroup_popen
branch
from
139a5a1 to
5b7d40b
Compare
Member
Author
|
We have a winner! |
Member
Author
|
No idea how to test this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5383 we added logic to create a new process group when doing
chdir in spawn, to avoid orphaning the eventual process spawned
by the intermediate sh. Unfortunately this has a side effect of
hanging on waitpid if the process spawns a long-running daemon.
This patch removes the process group and instead uses exec in the
generated sh script so that the sh process is replaced. The forked
daemon lives on, as it should, but only the main process is
waited on.
Fixes #6579