Optimization for calling java vararg methods on hotspot. ~10x speedup#6572
Merged
headius merged 1 commit intojruby:masterfrom Feb 23, 2021
Merged
Optimization for calling java vararg methods on hotspot. ~10x speedup#6572headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
Array.set is much slower than raw array access, and leads to a very laggy ui in certain JRubyFX workloads that involve lots of vararg calls to java apis. This patch optimizes that case, and leads to a resulting, user-visible ~10x speedup
headius
approved these changes
Feb 23, 2021
Member
|
Very nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array.set is much slower than raw array access, and leads to a very
laggy ui in certain JRubyFX workloads that involve lots of vararg
calls to java apis. This patch optimizes that case, and leads to a
resulting, user-visible ~10x speedup
This change was pulled out of #6422 work