[feat] support RubyString#split for Java (exts)#6562
Merged
kares merged 2 commits intojruby:masterfrom Mar 3, 2021
Merged
Conversation
Member
|
Big +1 for making the backref stuff more explicit. You have probably seen some Regexp functions where you can pass in a holder object or let it do the implicit operation, but this is a nice way to make it more typed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, there's no easy way to do a
RubyString#splitfrom a Java extension (due split writing a back-ref for the frame).the idea here is to provide a "strongly" typed API that Java consumers could leverage wout shooting themselves in the 🦶