Handle errors in Process.detach properly#6546
Merged
headius merged 2 commits intojruby:jruby-9.2from Feb 8, 2021
Merged
Conversation
The rb-waitpid function in CRuby does not actually trigger an exception raise when the waitpid errors, leaving that to callers to decide. Because ours did so, any errors during the Process.detach call to waitpid would trigger the raise event hook and unfix jruby#6466. This change moves the errno check outside of our rb_waitpid equivalent, making it safe to use in the Process.detach thread. Fixes jruby#6466 again.
headius
force-pushed
the
waitpid_no_exception
branch
from
262a9cd to
7bcf8d5
Compare
* Propagate long pid. * Push a dummy frame because of interrupts and thread events being able to raise an error during waitpid. Additional fix for jruby#6466.
Member
Author
|
An additional change was needed here because even with the previous commit errors may still get raised out of the blocking |
Member
Author
|
The reproduction case is complicated and I am unsure how best to add a spec for it. Basically, the reduced case looks like this: where |
headius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rb_waitpid function in CRuby does not actually trigger an
exception raise when the waitpid errors, leaving that to callers
to decide. Because ours did so, any errors during the
Process.detach call to waitpid would trigger the raise event hook
and unfix #6466.
This change moves the errno check outside of our rb_waitpid
equivalent, making it safe to use in the Process.detach thread.
Fixes #6466 again.