Revert racc default gem and copy manually#6537
Merged
Conversation
This only copies the parser supporting bits of racc to match Ruby 2.5, which does not include any of the parser generator sources. This still fixes #6507 but does not move racc to a default gem, both to match CRuby 2.5 and to avoid an undiagnosed build issue that stemmed from making racc a default gem.
This was referenced Feb 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6517
For some reason the PR in #6517 prevents our deploy from working on some environments, possibly due to the introduction of binscripts from gems. Rather than try to determine the problem, we are opting to remove the "defaultification" of the racc gem and will simply commit the relevant updated bits directly to the 9.2 branch. This will keep the fixed version of racc in place for #6507 but avoid the build and deploy issues.
Note that this does not affect master, which includes racc as a default gem and has no build issues.