Conversation
Member
Author
|
The most likely vector for compatibility issues here is the removal of MonitorMixin from Monitor's includes. Before, Monitor included MonitorMixin to get most of its functionality, but Monitor is the captain now. |
* Add classes to Ruby interface * Pass in everything needed to avoid self-referencing Ruby during init * Use method references for allocator
This mimics the change in CRuby 2.7 from this PR: ruby/ruby#2576 This makes the fixes from jruby#6527 and ruby/monitor#2 irrelevant due to the lack of Ruby interrupts in native code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ruby/ruby#2576 which did the same for CRuby 2.7.
This eliminates the need for the monitor.rb fixes in #6527 and ruby/monitor#2, plus synchronize will perform significantly better than the nested block implementation.
This may be safe to include in 9.3 even though the compatibility level is 2.6.