Merged
Conversation
There are not being generated or versioned by the FFI gem so we need to manage it ourselves.
These platforms are not part of the FFI gem and only exist in JRuby stdlib, but since we are attempting to source all non-native FFI code from the gem they should be moved there.
Member
Author
|
@larskanis The commit ee15993 deletes two platform |
larskanis
added a commit
to ffi/ffi
that referenced
this pull request
Dec 23, 2020
This file is moved from JRuby to ffi gem as part of jruby/jruby#6503
|
@headius I added the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of files under the
ffi/platformsubdir appear to have lineage back to the original addition of FFI support to JRuby and were used by Rubinius to support their own core and standard library classes that used FFI for implementation. Most of these files are no longer used by JRuby, and none of them are versioned by the FFI gem, so this PR will transplate or eliminate them.Most files are FFI constant declarations, while the
platform.conffiles appear to have been used internally by Rubinius. Of these files, only thesyslog.rbconstant definitions and thefcntlrelated files under x86-64 solaris appear to be in use in JRuby.Two platform
types.conffiles exist that do not appear to be in the FFI gem:i486-gnuplatformpowerpc64le-linuxplatformOf these two files, only the ppc file appears to be relevant, and should probably be contributed back to the FFI gem.