Fix Array shuffle and sample arity checking#6500
Merged
headius merged 3 commits intojruby:masterfrom Dec 16, 2020
Merged
Conversation
Member
Author
|
This fixes the missing arity error for shuffle and sample but I did not add any specs for these error conditions. |
Also fix splitting of shuffle
headius
force-pushed
the
array_shuffle_kwargs_arity
branch
from
59ee835 to
69334b7
Compare
Member
Author
|
Well crap, that was supposed to go to 9.2. I will cherry-pick I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing shuffle at first for #6499 but sample appears to have the same problem.